Show error when target is not visible in the Window section#31
Merged
jnation3406 merged 1 commit intomainfrom Aug 26, 2025
Merged
Show error when target is not visible in the Window section#31jnation3406 merged 1 commit intomainfrom
jnation3406 merged 1 commit intomainfrom
Conversation
jnation3406
commented
Aug 20, 2025
| computed: { | ||
| topLevelErrors: function() { | ||
| return extractTopLevelErrors(this.errors); | ||
| let combinedError = extractTopLevelErrors(this.errors); |
Member
Author
There was a problem hiding this comment.
this.errors comes from a prop passed down from the parent, and will have errors on specific fields. The airmassData can also have an error (if there is an error with visibility), in which case this code below should include that in the error list shown at the top of this component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is stuff Blanco requested, but I think it makes sense for everyone. Two changes:
Request Namefrom justName- I guess it was confusing since some people thought it meant a persons name should go there./airmass/endpoint is incorporated into the Window section error, so if a target is not visible, the window visibility error should show up in the Window section and at the top of the Request.